Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expect: Revert change to distinguish undefined value from no property #8067

Merged
merged 2 commits into from
Mar 6, 2019
Merged

expect: Revert change to distinguish undefined value from no property #8067

merged 2 commits into from
Mar 6, 2019

Conversation

pedrottimark
Copy link
Contributor

Summary

For more information, see #7986 (comment)

Test plan

Commented out one test until it is time to make a breaking change

@pedrottimark pedrottimark requested a review from mjesun March 6, 2019 18:34
mjesun
mjesun approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@mjesun mjesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @SimenB do we want to signal this better so that we don't forget to include it for Jest 25? It's definitely a change I'd be happy having into, especially if we fix this behavior from toEqual and other places.

@pedrottimark
Copy link
Contributor Author

What do you think if I open an issue and assign it to Jest 25 milestone.

@mjesun
Copy link
Contributor

mjesun commented Mar 6, 2019

Yeah, that sounds awesome!

@SimenB
Copy link
Member

SimenB commented Mar 6, 2019

What do you think if I open an issue and assign it to Jest 25 milestone.

Sounds perfect

@mjesun mjesun merged commit f2af727 into jestjs:master Mar 6, 2019
@pedrottimark pedrottimark deleted the toHaveProperty-undefined branch March 6, 2019 18:54
@rubennorte rubennorte mentioned this pull request Mar 7, 2019
Merged
@jeysal jeysal mentioned this pull request Aug 6, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
This was referenced Mar 21, 2020
Closed
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@mjesun mjesun mjesun approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedrottimark @mjesun @SimenB @facebook-github-bot